Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix): Allow override of primary key type #1430

Merged
merged 26 commits into from
Dec 22, 2023
Merged

(fix): Allow override of primary key type #1430

merged 26 commits into from
Dec 22, 2023

Conversation

JeSuisAlrick
Copy link
Contributor

@JeSuisAlrick JeSuisAlrick commented Dec 9, 2023 •
edited by nicolas63
Loading

@JeSuisAlrick JeSuisAlrick mentioned this pull request Dec 9, 2023
Closed
1 task
@JeSuisAlrick JeSuisAlrick changed the title (fix): Allow override of primary key type Resolves: Preference for primary key in JDL not respected #1428 Dec 9, 2023
@JeSuisAlrick JeSuisAlrick changed the title Resolves: Preference for primary key in JDL not respected #1428 Resolves: Preference for primary key in JDL not respected Dec 9, 2023
@JeSuisAlrick JeSuisAlrick changed the title Resolves: Preference for primary key in JDL not respected (fix): Allow override of primary key type Dec 9, 2023
@nicolas63 nicolas63 marked this pull request as ready for review December 12, 2023 05:39
@nicolas63
Copy link
Member

Very nice work ! I will test it soon. The sonar analysis is not a problem

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 21, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

39.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

nicolas63
nicolas63 approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@nicolas63 nicolas63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, if you agree, I can merge it.

@JeSuisAlrick
Copy link
Contributor Author

Everything looks good, if you agree, I can merge it.

Yeah. I'm good with the changes.

I'm considering migrations as the next thing to work on, but I'll support this change.

@nicolas63 nicolas63 merged commit 48f7d73 into jhipster:main Dec 22, 2023
26 of 27 checks passed
@nicolas63
Copy link
Member

Merged, thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas63 nicolas63 nicolas63 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JeSuisAlrick @nicolas63 @KCL-TelferAA